Review Request: Minor cleanups and improvements in the KineticScrolling

Zack Rusin zack at kde.org
Sat Mar 13 01:53:20 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3276/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Cleanups and improvements to the KineticScrolling class.

This code really needs to be in Plasma::ScrollWidget where it's a lot easier to filter child events, but for the time being this patch cleans up the Plasma::KineticScrolling a bit and makes the physics model a little better (still not ideal though). 


Diffs
-----

  /trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp 1102194 
  /trunk/KDE/kdelibs/plasma/private/kineticscroll_p.h 1102194 

Diff: http://reviewboard.kde.org/r/3276/diff


Testing
-------

In a custom app, mainly vertical flicking.


Thanks,

Zack



More information about the Plasma-devel mailing list