Review Request: The WebshortcutRunner did not check whether the search engines it provided were even enabled.

[Aaron J. Seigo]

On March 12, 2010, Nikolaus Waxweiler wrote:
> > On 2010-03-08 14:40:14, Nikolaus Waxweiler wrote:
> > > wait. something's not right. location in WebshortcutRunner::run(...) is
> > > empty.
> > 
> > Nikolaus Waxweiler wrote:
> >     huh. the bug seems to elsewhere as earlier revisions have the same
> >     bug. the result is that this runner doesn't do anything.
> > 
> > Nikolaus Waxweiler wrote:
> >     did a svn up and now it works. oh well *shrug
> 
> By the way, anybody know why in line 63 ("KConfig
> kuriconfig("kuriikwsfilterrc", KConfig::NoGlobals);") it says
> "KConfig::NoGlobals"? When you start a fresh KDE, this runner won't do
> anything because no local kuriikwsfilterrc has been written yet...

because this is what the code in kdebase/runtime/kurifilter-plugins/ikws/ also 
does. why it does that, i don't know. you'd have to ask the author/maintainer 
of ikws. :)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks