Review Request: Status notifier item data engine

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3266/#review4483
-----------------------------------------------------------

Ship it!


apart some style issues this should go in because the modifications are already too big (Aurelien has a patch on it too, you should also update to include it one he committed)

- Marco


On 2010-03-11 21:34:08, Matthieu Gallien wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3266/
> -----------------------------------------------------------
> 
> (Updated 2010-03-11 21:34:08)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Data engine that exposes one source by status notifier item.
> The code is a copy of the code from Marco Martin and that is in the systray applet dbus protocol.
> I will when I found enough time review that I did not introduce any bug or that I miss any modifications that occured in the applet code.
> I started this work several months ago, so I may be missing something.
> 
> 
> Diffs
> -----
> 
>   /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt PRE-CREATION 
>   /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/plasma_engine_statusnotifieritem.desktop PRE-CREATION 
>   /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritem.operations PRE-CREATION 
>   /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritem_engine.h PRE-CREATION 
>   /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp PRE-CREATION 
>   /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemjob.h PRE-CREATION 
>   /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemjob.cpp PRE-CREATION 
>   /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemservice.h PRE-CREATION 
>   /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemservice.cpp PRE-CREATION 
>   /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.h PRE-CREATION 
>   /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.cpp PRE-CREATION 
>   /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifierwatcher/CMakeLists.txt PRE-CREATION 
>   /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifierwatcher/statusnotifierwatcher.desktop PRE-CREATION 
>   /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifierwatcher/statusnotifierwatcher.h PRE-CREATION 
>   /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifierwatcher/statusnotifierwatcher.cpp PRE-CREATION 
>   /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/systemtraytypes.h PRE-CREATION 
>   /kde/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/systemtraytypes.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/3266/diff
> 
> 
> Testing
> -------
> 
> Tested in plasmaengineexplorer.
> 
> 
> Thanks,
> 
> Matthieu
> 
>