Review Request: Add IconThemePath to org.kde.StatusNotifierItem 1/2

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3261/
-----------------------------------------------------------

(Updated 2010-03-11 17:04:44.825219)


Review request for Plasma.


Summary (updated)
-------

(This is part 1/2 of the IconThemePath patch, part 2 is here: http://reviewboard.kde.org/r/3262/ )

Applications may wish to use icons which are installed in $KDEDIR/share/apps/$app/icons in their StatusNotifierItem. To do so they need to publish the dir where these icons are installed. This can be done by adding an IconThemePath property to the StatusNotifierItem, pointing to an application-specif icon theme dir.

The patch adds the property and initialize it with the first dir returned by KGlobal::dirs()->findDirs("appdata", "icons")


Diffs
-----

  trunk/KDE/kdelibs/kdeui/notifications/kstatusnotifieritem.cpp 1101797 
  trunk/KDE/kdelibs/kdeui/notifications/kstatusnotifieritemdbus_p.h 1101797 
  trunk/KDE/kdelibs/kdeui/notifications/kstatusnotifieritemdbus_p.cpp 1101797 
  trunk/KDE/kdelibs/kdeui/notifications/kstatusnotifieritemprivate_p.h 1101797 
  trunk/KDE/kdelibs/kdeui/notifications/org.kde.StatusNotifierItem.xml 1101797 
  trunk/KDE/kdelibs/kdeui/tests/kstatusnotifieritemtest.cpp 1101797 

Diff: http://reviewboard.kde.org/r/3261/diff


Testing
-------

(To test you need to apply http://reviewboard.kde.org/r/3262/ which makes the systemtray applet aware of this new property)

- Create $KDEDIR/share/apps/kstatusnotifieritem/icons/hicolor/22x22/
- Copy a 22x22 icon in this dir under the name customicon.png
- Start kstatusnotifieritemtest with "--active-icon customicon.png"
- Icon in the systemtray applet should be customicon.png


Thanks,

Aurélien