Review Request: Add IconThemePath to org.kde.StatusNotifierItem 2/2

Aurélien Gâteau agateau at kde.org
Thu Mar 11 18:04:30 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3262/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

(This is part 2/2 of the IconThemePath patch, part 1 is here: http://reviewboard.kde.org/r/3261/ )

Applications may wish to use icons which are installed in $KDEDIR/share/apps/$app/icons in their StatusNotifierItem. To do so they need to publish the dir where these icons are installed. This can be done by adding an IconThemePath property to the StatusNotifierItem, pointing to an application-specif icon theme dir.

The patch makes the systemtray applet aware of the IconThemePath property. To avoid clashes between icons from different applications it creates a separate KIconLoader for each item.


Diffs
-----

  trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h 1101859 
  trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp 1101859 

Diff: http://reviewboard.kde.org/r/3262/diff


Testing
-------

See http://reviewboard.kde.org/r/3261/


Thanks,

Aurélien



More information about the Plasma-devel mailing list