Review Request: Quicklaunch applet: Change icon order

[Ingomar Wesp]

> On 2010-03-10 22:42:51, Lukas Appelhans wrote:
> > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunchApplet.cpp, line 296
> > <http://reviewboard.kde.org/r/3254/diff/1/?file=20615#file20615line296>
> >
> >     again no need for QGraphicsGridLayout:: :)

Argh. You're right, I forgot to remove the explicit superclass calls after I removed addItem() from QuicklaunchLayout.

Thanks for pointing that out.


- Ingomar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3254/#review4461
-----------------------------------------------------------


On 2010-03-10 22:32:10, Ingomar Wesp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3254/
> -----------------------------------------------------------
> 
> (Updated 2010-03-10 22:32:10)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Since there were no objections on plasma-devel, I'm now posting a review request for a patch that changes the icon order in the quicklaunch applet.
> 
> Currently, icons are arranged in column major order. Thus, when 5 icons are 
> displayed in two rows, the indices are distributed as follows:
> 
> +---+---+---+
> | 0 | 2 | 4 |
> +---+---+---+
> | 1 | 3 |
> +---+---+
> 
> This patch changes the arrangement to row major order instead:
> 
> +---+---+---+
> | 0 | 1 | 2 |
> +---+---+---+
> | 3 | 4 |
> +---+---+
> 
> Additionally, I have removed QuicklaunchLayout::addItem(...). Its only caller - QuicklaunchApplet::performUiRefactor() - already knows the number of rows and columns, so there is no need to recompute them. In the long term, I'd like to remove QuicklaunchLayout and move layouting and drag/drop into a dedicated widget class (QuicklaunchIconGrid maybe).
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/QuicklaunchLayout.h 1100817 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/QuicklaunchLayout.cpp 1100882 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunchApplet.cpp 1100902 
> 
> Diff: http://reviewboard.kde.org/r/3254/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ingomar
> 
>