Review Request: merging screen edges settings.

[Lubos Lunak]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3240/#review4458
-----------------------------------------------------------

Ship it!


Looks ok to me.

One small nitpick: Please do not do
Foo* foo = new Foo;
foo->doSomething();
delete foo;

The object can be normally allocated on the stack without risking a leak or requiring the extra work of dynamic allocation.

- Lubos


On 2010-03-10 00:05:27, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3240/
> -----------------------------------------------------------
> 
> (Updated 2010-03-10 00:05:27)
> 
> 
> Review request for Plasma, Martin Gräßlin and Lubos Lunak.
> 
> 
> Summary
> -------
> 
> 1) Removed "Advanced Button" from screensaver kcm.
> 2) Screensaver screen edges settings have been merged with kwin screen edges settings.
> 3) Removed screensaver priority configuration: we assume that users don't need to change screensaver priority.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/kcontrol/screensaver/CMakeLists.txt 1101220 
>   /trunk/KDE/kdebase/workspace/kcontrol/screensaver/advanceddialog.h 1101220 
>   /trunk/KDE/kdebase/workspace/kcontrol/screensaver/advanceddialog.cpp 1101220 
>   /trunk/KDE/kdebase/workspace/kcontrol/screensaver/advanceddialogimpl.ui 1101220 
>   /trunk/KDE/kdebase/workspace/kcontrol/screensaver/screensaver.ui 1101220 
>   /trunk/KDE/kdebase/workspace/kcontrol/screensaver/scrnsave.h 1101220 
>   /trunk/KDE/kdebase/workspace/kcontrol/screensaver/scrnsave.cpp 1101220 
>   /trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinscreenedges/main.cpp 1101220 
>   /trunk/KDE/kdebase/workspace/kwin/lib/kwinglobals.h 1101220 
>   /trunk/KDE/kdebase/workspace/kwin/options.cpp 1101220 
>   /trunk/KDE/kdebase/workspace/kwin/workspace.cpp 1101220 
> 
> Diff: http://reviewboard.kde.org/r/3240/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
>