Review Request: The WebshortcutRunner did not check whether the search engines it provided were even enabled.
Nikolaus Waxweiler
madigens at gmail.com
Mon Mar 8 20:36:29 CET 2010
> On 2010-03-08 14:40:14, Nikolaus Waxweiler wrote:
> > wait. something's not right. location in WebshortcutRunner::run(...) is empty.
>
> Nikolaus Waxweiler wrote:
> huh. the bug seems to elsewhere as earlier revisions have the same bug. the result is that this runner doesn't do anything.
did a svn up and now it works. oh well *shrug
- Nikolaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3097/#review4420
-----------------------------------------------------------
On 2010-03-07 23:22:31, Nikolaus Waxweiler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3097/
> -----------------------------------------------------------
>
> (Updated 2010-03-07 23:22:31)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Solution: find out which ones are enabled and compare before presenting a match/advertising a search engine.
>
> I added a QStringList m_enabledSearchEngines which is updated after every relevant change to sycoca and changed 2 places in the runner to query it: when building the runner-help-string to be displayed via krunner's [?]-button and when looking if the first word of the user's string could possibly be a shorthand for/keyword of a search engine.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp 1100546
>
> Diff: http://reviewboard.kde.org/r/3097/diff
>
>
> Testing
> -------
>
> Used rev. 1098255 as the starting point. Compiled it and overwrote the 4.4.1 .so I had installed. Because I'm lazy. I experienced some krunner-crashes, maybe because of this :p Didn't check though. Because I'm lazy.
>
> I then typed the shorthand for some search engine I had disabled ("amg") to check whether the runner would respond. Nope. I then enabled it and ran kbuildsycoca4 manually (the web shortcut dialog in konq. is unreliable with this.. I think there's a few bug reports for this), and the runner responded appropriately. Other shortcuts worked fine.
>
>
> Thanks,
>
> Nikolaus
>
>
More information about the Plasma-devel
mailing list