Review Request: Don't connect the same signals to the same slots for the same objects several times.

[Espen Hustad]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3142/
-----------------------------------------------------------

(Updated 2010-03-07 20:36:50.705571)


Review request for Plasma.


Changes
-------

StartupCompletedConstraint is being sent twice int DesktopCorona::addPanel, once addContainment, and the second time with updateConstraints.


Summary
-------

Applet::flushPendingConstraintsEvents() is called several times with Plasma::StartupCompletedConstraint as the pending constraint, this leads to multiple connections of the same signals and slots for the same objects. This leads to the double cancel reported in bug #215362. 

The following patch sets the connectiontype to Qt::UniqueConnection for all the connections, as it doesn't make sense to connect the same signals and slots several times.


This addresses bug 215362.
    https://bugs.kde.org/show_bug.cgi?id=215362


Diffs (updated)
-----

  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/desktop/shell/desktopcorona.cpp 1100546 

Diff: http://reviewboard.kde.org/r/3142/diff


Testing
-------

Added a few panels and removed them again, the cancel and remove now works as intended.


Thanks,

Espen