Review Request: frame plasmoid: image load and scaling with threads
Aaron Seigo
aseigo at kde.org
Sat Mar 6 19:17:15 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3162/#review4398
-----------------------------------------------------------
+1 on removing "smooth scaling" from the options.
- Aaron
On 2010-03-06 17:54:04, Davide Bettio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3162/
> -----------------------------------------------------------
>
> (Updated 2010-03-06 17:54:04)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> First of all: **This is a preview of the patch** I'm still working on it but I need some advices.
> Picture Frame does 2 really bad things (when used with huge images):
> * it loads huge images (in my case 4000x3000 pixels) into X11 pixmaps
> * plasma is blocked while the image is scaled
> As side effect also X11 freezes.
>
> This patch solves both issues using threads.
>
> I think that we should remove "smooth scaling" option from our configuration UI. what do you think?
>
>
> Diffs
> -----
>
> /trunk/KDE/kdeplasma-addons/applets/frame/CMakeLists.txt 1093624
> /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1093624
> /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1093624
> /trunk/KDE/kdeplasma-addons/applets/frame/imageloader.cpp PRE-CREATION
> /trunk/KDE/kdeplasma-addons/applets/frame/imagescaler.cpp PRE-CREATION
> /trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1093624
> /trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1093624
> /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1093624
> /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1093624
>
> Diff: http://reviewboard.kde.org/r/3162/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Davide
>
>
More information about the Plasma-devel
mailing list