Review Request: Don't connect the same signals to the same slots for the same objects several times.
Espen Hustad
espen at ehustad.com
Fri Mar 5 01:44:35 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3142/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
Applet::flushPendingConstraintsEvents() is called several times with Plasma::StartupCompletedConstraint as the pending constraint, this leads to multiple connections of the same signals and slots for the same objects. This leads to the double cancel reported in bug #215362.
The following patch sets the connectiontype to Qt::UniqueConnection for all the connections, as it doesn't make sense to connect the same signals and slots several times.
This addresses bug 215362.
https://bugs.kde.org/show_bug.cgi?id=215362
Diffs
-----
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/applet.cpp 1099054
Diff: http://reviewboard.kde.org/r/3142/diff
Testing
-------
Added a few panels and removed them again, the cancel and remove now works as intended.
Thanks,
Espen
More information about the Plasma-devel
mailing list