Review Request: Manual panel hiding [WIP]

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3121/#review4384
-----------------------------------------------------------



/trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.cpp
<http://reviewboard.kde.org/r/3121/#comment3882>

    apart that ToolButton should be used instead, don't really like a fuction that does enabling -and- repositioning in one.
    positioning should be done by a layout, really


- Marco


On 2010-03-04 19:19:53, Andrzej JR Hunt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3121/
> -----------------------------------------------------------
> 
> (Updated 2010-03-04 19:19:53)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Manual panel hiding patch (still in progress). Currently only horizontal panels are properly implemented, there is still a display bug whereby the plasma toolbox (cashew) ignores the contentsMargins set on the containment and thus gets covered by the hiding buttons.
> 
> 
> This addresses bug 158556.
>     https://bugs.kde.org/show_bug.cgi?id=158556
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.h 1097398 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.cpp 1097398 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.h 1097398 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.cpp 1097398 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/scripting/panel.cpp 1097398 
> 
> Diff: http://reviewboard.kde.org/r/3121/diff
> 
> 
> Testing
> -------
> 
> Hiding the panels, changing states, changing positions and sizes.
> 
> 
> Thanks,
> 
> Andrzej JR
> 
>