Review Request: The WebshortcutRunner did not check whether the search engines it provided were even enabled.

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3097/#review4375
-----------------------------------------------------------

Ship it!


looks great, and certainly an improvement in many ways. thanks! :)

it seems you don't have an account, so i'll commit this one for you. if you continue to contribute patches such as this one, we'll have to hook you up with your own svn account :)

- Aaron


On 2010-03-04 15:34:42, Nikolaus Waxweiler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3097/
> -----------------------------------------------------------
> 
> (Updated 2010-03-04 15:34:42)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Solution: find out which ones are enabled and compare before presenting a match/advertising a search engine.
> 
> I added a QStringList m_enabledSearchEngines which is updated after every relevant change to sycoca and changed 2 places in the runner to query it: when building the runner-help-string to be displayed via krunner's [?]-button and when looking if the first word of the user's string could possibly be a shorthand for/keyword of a search engine.
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.4/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.h 1098255 
>   /branches/KDE/4.4/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp 1098255 
> 
> Diff: http://reviewboard.kde.org/r/3097/diff
> 
> 
> Testing
> -------
> 
> Used rev. 1098255 as the starting point. Compiled it and overwrote the 4.4.1 .so I had installed. Because I'm lazy. I experienced some krunner-crashes, maybe because of this :p Didn't check though. Because I'm lazy.
> 
> I then typed the shorthand for some search engine I had disabled ("amg") to check whether the runner would respond. Nope. I then enabled it and ran kbuildsycoca4 manually (the web shortcut dialog in konq. is unreliable with this.. I think there's a few bug reports for this), and the runner responded appropriately. Other shortcuts worked fine.
> 
> 
> Thanks,
> 
> Nikolaus
> 
>