Review Request: Added support to multiple render threads to Plasma::Wallpaper.

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3092/#review4361
-----------------------------------------------------------


two small issues, and then it looks good to go! :)


/trunk/KDE/kdelibs/plasma/wallpaper.cpp
<http://reviewboard.kde.org/r/3092/#comment3852>

    according to Qt docs, this doesn't work reliably across threads in all cases; include the WallpaperRenderThread* in the signal and slot signatures and then it's fail proof.



/trunk/KDE/kdelibs/plasma/wallpaper.cpp
<http://reviewboard.kde.org/r/3092/#comment3851>

    this will stall at the first null parent; it probably should be:
    
    while (!s_renderQueue.isEmpty()) {
        WallpaperPrivate::RenderRequest request = s_renderQueue.dequeue();
        if (!request.parent) {
             continue;
         }
    
         ... do the render request ...
    }


- Aaron


On 2010-03-03 23:55:34, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3092/
> -----------------------------------------------------------
> 
> (Updated 2010-03-03 23:55:34)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds support to multiple render threads in Plasma::Wallpaper and fixes a small bug that has been happening when there wasn't any wallpaper in the wallpaper cache.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/private/wallpaper_p.h 1098381 
>   /trunk/KDE/kdelibs/plasma/private/wallpaperrenderthread.cpp 1098381 
>   /trunk/KDE/kdelibs/plasma/private/wallpaperrenderthread_p.h 1098381 
>   /trunk/KDE/kdelibs/plasma/wallpaper.cpp 1098381 
> 
> Diff: http://reviewboard.kde.org/r/3092/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
>