Review Request: Added support to multiple render threads to Plasma::Wallpaper.

[Davide Bettio]

> On 2010-03-03 17:05:34, Aaron Seigo wrote:
> > "This patch adds support to multiple render threads in Plasma::Wallpaper"
> > 
> > sounds like it could be useful; is there a use case in particular that you were working on that this improves?
> > 
> > "and fixes a small bug that has been happening when there wasn't any wallpaper in the wallpaper cache."
> > 
> > what was the fix? (i didn't notice it in the patch :)
> 
> Davide Bettio wrote:
>     The case is when plasma has to render more than one image in the same time (when rendering N wallpaper for N activities when the cache is empty), multithreading is here for free with few changes.
>     
>     The bug has been happening with cache on tmpfs, so the cache is erased during every reboot. The old code doesn't work when there are more than one render request (the previous request was always replaced with the new one), the fix is the queue.
> 
> Beat Wolf wrote:
>     does this potentialy fix the black wallpaper bug on multiscreen setups? just wondering

I don't know, buy me another monitor and I can tell you... or just try the patch ;)


- Davide


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3092/#review4348
-----------------------------------------------------------


On 2010-03-03 15:47:34, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3092/
> -----------------------------------------------------------
> 
> (Updated 2010-03-03 15:47:34)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds support to multiple render threads in Plasma::Wallpaper and fixes a small bug that has been happening when there wasn't any wallpaper in the wallpaper cache.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/private/wallpaper_p.h 1097236 
>   /trunk/KDE/kdelibs/plasma/wallpaper.cpp 1097236 
> 
> Diff: http://reviewboard.kde.org/r/3092/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
>