Review Request: Fixes for screen hotplugging

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4451/#review6266
-----------------------------------------------------------

Ship it!


looks good; i've committed this patch as it seems you don't have an svn account? (if you would like to continue working on these kinds of patches, we can hook you up with one)

- Aaron


On 2010-06-24 15:39:08, Anthony Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4451/
> -----------------------------------------------------------
> 
> (Updated 2010-06-24 15:39:08)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Aaron's patch almost fixed the problem, but there's still the issue that the view is getting created on startup even if its screen does not exist.
> I've added a few checks in createWaitingDesktops() to make sure a view is only created if it's for a containment with a valid screen and desktop.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.cpp 1142286 
> 
> Diff: http://reviewboard.kde.org/r/4451/diff
> 
> 
> Testing
> -------
> 
> Started plasma with and without an external screen and tried adding and removing it a few times, with and without per virtual desktop views.
> 
> 
> Thanks,
> 
> Anthony
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100624/f58b2495/attachment-0001.htm