Review Request: Fixes for screen hotplugging

[Anthony Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4451/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

This patch fixes a few problems that occur when hotplugging screens:
1. On startup, existing containments are associated with a screen even if that screen does not exist.
   This causes a bug when a screen is added: since the containment already thinks it is associated with the new screen,
   it doesn't emit screenChanged() with the new screen, and doesn't get a view created for it.
   To fix this, I've made Containment::setScreen() set the new screen to -1 if it doesn't exist.
2. When a screen is removed, a containment will remain associated with the screen that it is on, causing the same bug
   as in 1 when the screen is added again.
   To fix this, I've made sure a containment's screen is set to -1 when its view is removed by PlasmaApp.
3. PlasmaApp tries to connect to a nonexistent signal in Kephal: screenAdded(int), the real one is screenAdded(Kephal::Screen*)

I'm not completely sure that this is the best way of fixing these problems, please correct me if it isn't.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.h 1141983 
  /trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.cpp 1141983 
  /trunk/KDE/kdelibs/plasma/containment.cpp 1141983 

Diff: http://reviewboard.kde.org/r/4451/diff


Testing
-------

Started plasma with and without an external screen and tried adding and removing it a few times.


Thanks,

Anthony

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100624/ae9c7050/attachment.htm