Review Request: Better behaviour of the bookmarks runner regarding Firefox

[Jan Gerrit Marker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4414/
-----------------------------------------------------------

(Updated 2010-06-22 16:41:18.325281)


Review request for Plasma.


Changes
-------

Correct the last fix about context validation.


Summary
-------

Corrects the behavior of the bookmarks runner regarding Firefox:
1. Firefox intern bookmarks (like the "Recently used bookmarks" folder) are not shown
2. Only bookmarks with a non empty name and url are shown
3. The profile written to the config file is updated if it does not exist anymore

Additionally I polished the Firefox regarding method.
I did not commit directly because I was not sure whether it is allowed at this point of the KDE SC development.


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp 1141326 

Diff: http://reviewboard.kde.org/r/4414/diff


Testing
-------

I have tested it with current trunk - everything seems to be ok.


Thanks,

Jan Gerrit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100622/81f3752e/attachment.htm