Review Request: Twitter OAuth support for microblog dataengine

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4440/#review6230
-----------------------------------------------------------

Ship it!


even if it can be seen as a feature it's pretty important that goes in asap, before 4.5
btw, looking at the patch they shouldn't, but did you see if doesn't interfere with identica?

- Marco


On 2010-06-22 11:47:11, Ryan Bitanga wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4440/
> -----------------------------------------------------------
> 
> (Updated 2010-06-22 11:47:11)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds oauth support for the microblog dataengine when used with twitter. No changes need to be made to the applet.
> 
> Helper functions for signature generation and conversion of http request parameters to strings were based on qoauth by Dominik Kapusta.
> 
> 
> This addresses bug 242048.
>     https://bugs.kde.org/show_bug.cgi?id=242048
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/dataengines/microblog/CMakeLists.txt 1141257 
>   /trunk/KDE/kdeplasma-addons/dataengines/microblog/oauth.h PRE-CREATION 
>   /trunk/KDE/kdeplasma-addons/dataengines/microblog/oauth.cpp PRE-CREATION 
>   /trunk/KDE/kdeplasma-addons/dataengines/microblog/timelinesource.h 1141257 
>   /trunk/KDE/kdeplasma-addons/dataengines/microblog/timelinesource.cpp 1141257 
> 
> Diff: http://reviewboard.kde.org/r/4440/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100622/3cbf7d8f/attachment.htm