Review Request: Better behaviour of the bookmarks runner regarding Firefox

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4414/#review6197
-----------------------------------------------------------


i think the patch is ok, i am concerned too about committing so late a change that is not exactly trivial

- Marco


On 2010-06-20 16:40:04, Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4414/
> -----------------------------------------------------------
> 
> (Updated 2010-06-20 16:40:04)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Corrects the behavior of the bookmarks runner regarding Firefox:
> 1. Firefox intern bookmarks (like the "Recently used bookmarks" folder) are not shown
> 2. Only bookmarks with a non empty name and url are shown
> 3. The profile written to the config file is updated if it does not exist anymore
> 
> Additionally I polished the Firefox regarding method.
> I did not commit directly because I was not sure whether it is allowed at this point of the KDE SC development.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp 1140335 
> 
> Diff: http://reviewboard.kde.org/r/4414/diff
> 
> 
> Testing
> -------
> 
> I have tested it with current trunk - everything seems to be ok.
> 
> 
> Thanks,
> 
> Jan Gerrit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100620/2480ebbd/attachment.htm