Review Request: Fix some Event/Todo problems in Plasma Calendar

[John Layt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4387/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Fix some problems and make some improvements:
1) Todo items were not being cached or displayed as they don't have a StartDate. Instead return the TodoDueDate and other Todo details in the DataContainer for clients to use.  Use the TodoDueDate to index and display Todo's, other details cannot be added due to string freeze (do in 4.6).
2) Only show Event times in Calendar pop-up, not dates as pop-up is for a single date anyway
3) Tweak the whitespace in the pop-up
4) Cache Events/Todos as Data rather than display strings, only format display strings at point of display
5) Generally make Event/Todo code more consistent with Holiday code

What still doesn't work correctly:
1) Recurring events only show first occurrence
2) Date range filter does not work, all Akonadi Events/Todos are returned and cached
3) New or modified Events/Todo's (e.g. in KOrganizer) do not auto-update in plasma as they should
4) There might be an issue with multi-day events not displaying on correct days
5) There might be issues with timezones

Still looking into these, may need help from the pimsters to work out why.


Diffs
-----

  trunk/KDE/kdebase/workspace/libs/plasmaclock/calendartable.cpp 1139216 
  trunk/KDE/kdebase/workspace/plasma/generic/dataengines/calendar/eventdatacontainer.cpp 1137927 

Diff: http://reviewboard.kde.org/r/4387/diff


Testing
-------

Usual rounds of testing with plasmoidviewer and akonadi resources with plenty of events and todos.


Thanks,

John

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100619/49f7d266/attachment.htm