Review Request: Make plasmapkg work for languages in which package types have capital letters

Matteo Agostinelli agostinelli at gmail.com
Wed Jun 16 12:15:29 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4339/
-----------------------------------------------------------

Review request for Plasma and Aaron Seigo.


Summary
-------

Trivial fix for bug https://bugs.kde.org/show_bug.cgi?id=230645. Since type is defined as:
QString type = args->getOption("type").toLower()
the subsequent checks should be made for lower case strings.


This addresses bug 230645.
    https://bugs.kde.org/show_bug.cgi?id=230645


Diffs
-----

  /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp 1138554 

Diff: http://reviewboard.kde.org/r/4339/diff


Testing
-------

Compiles and works


Thanks,

Matteo



More information about the Plasma-devel mailing list