Review Request: new KWin effect: Dashboard

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4332/#review6130
-----------------------------------------------------------


nice to see this moving forward! it looks ok from the plasma side, though that covers only the more trivial parts of this patch. :) 

once this is in, then the next step would be to put kwin in charge of actually displaying the dashboard window, meaning keeping it above other windows, etc. then when this effect exists, we could perhaps do some work on plasma-desktop to get rid of the separate dashboard window when dashboard=desktop (the default) is on. this would increase efficiency (half the repaints, less memory usage) and get rid of some odd mis-features. the biggest bit of work would involved be to switch the current wallpaper plugin to paint the wallpaper on a different full-screen widget that would be the desktop when it is being shown as the dashboard. (otherwise, there would be no wallpaper shown!) fortunately, wallpaper painting is a separate plugin these days, so this should be doable ... 


trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp
<http://reviewboard.kde.org/r/4332/#comment5732>

    _KDE_DASHBOARD is a bit generic; i wonder if we should be namespacing these a bit better, e.g. _WM_EFFECT_KDE_DASHBOARD? something the kwin folk can comment on better than i, probably.



trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp
<http://reviewboard.kde.org/r/4332/#comment5733>

    that is quite the hack; this should be replaced with another method in Plasma::WindowEffects .. markAsDashboard? internally it can set an appropriate atom or window class (whatever is best from kwin's POV) and that can be called in DashboardView's ctor in plasma-desktop.


- Aaron


On 2010-06-15 20:31:15, Andreas Demmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4332/
> -----------------------------------------------------------
> 
> (Updated 2010-06-15 20:31:15)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds a new KWin effect that allows to modify the appearance of the Plasma dashboard. It has a KCM configuration dialog where you can adjust brightness, saturation and blur of the dashboard background. Blur depends on the loaded blur plugin.
> 
> I also patched the Plasma dashboard to recognize the loaded effect: If the effect is loaded, the dashboard draws its background fully translucent. In order for the Dashboard to recognize wether the effect is loaded, I added support for the effect in Plasma::WindowEffects from kdelibs.
> 
> The dashboard detection in the effect itself is hackish right now. As soon as Plasma adds a proper class to the dashboard window, I will replace the hack with a class-check.
> 
> 
> This addresses bugs dashboard, detection and hackish.
>     https://bugs.kde.org/show_bug.cgi?id=dashboard
>     https://bugs.kde.org/show_bug.cgi?id=detection
>     https://bugs.kde.org/show_bug.cgi?id=hackish
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt 1138357 
>   trunk/KDE/kdebase/workspace/kwin/effects/configs_builtins.cpp 1138357 
>   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/CMakeLists.txt PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.h PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.desktop PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.ui PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboardeffectconfig.ui PRE-CREATION 
>   trunk/KDE/kdebase/workspace/plasma/desktop/shell/dashboardview.cpp 1138357 
>   trunk/KDE/kdelibs/plasma/windoweffects.h 1138355 
>   trunk/KDE/kdelibs/plasma/windoweffects.cpp 1138355 
> 
> Diff: http://reviewboard.kde.org/r/4332/diff
> 
> 
> Testing
> -------
> 
> Code compiles, plugin loads, plugin configuration dialog is registered in KCM Workspace module under "all effects". If the plugin is enabled, its settings apply to the dashboard.
> 
> 
> Screenshots
> -----------
> 
> configuration dialog
>   http://reviewboard.kde.org/r/4332/s/434/
> dashboard with modified background
>   http://reviewboard.kde.org/r/4332/s/435/
> 
> 
> Thanks,
> 
> Andreas
> 
>