Review Request: Make it possible to tell the Corona what global configuration to use

Aaron Seigo aseigo at kde.org
Thu Jun 10 17:52:18 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4272/#review6078
-----------------------------------------------------------


in Corona there is loadLayout and importLayout; loadLayout takes a configuration file name, and it is required to be called during Corona setup. the difference between load and import should probably be that loadLayout sets that config file as the target destination file, while import simply does a one-off importation of the data in the config. that will avoid another constructor and making this a decision that needs to be made in the code when the corona is created.

see r1136734.

- Aaron


On 2010-06-09 23:40:52, Aleix Pol wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4272/
> -----------------------------------------------------------
> 
> (Updated 2010-06-09 23:40:52)
> 
> 
> Review request for Plasma, Aaron Seigo and Ryan Rix.
> 
> 
> Summary
> -------
> 
> As I told you, I need to be able to set the configuration file to be used in some specific instance. Since I'm not familiar with the code I decided to keep the patch to a minimum so that we can get to something we all like.
> 
> Context: KDevelop Dashboard. Per project Plasma instances, the config file is the project file.
> 
> Hope it's useful :)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/corona.h 1136038 
>   trunk/KDE/kdelibs/plasma/corona.cpp 1136038 
> 
> Diff: http://reviewboard.kde.org/r/4272/diff
> 
> 
> Testing
> -------
> 
> None
> 
> 
> Thanks,
> 
> Aleix
> 
>



More information about the Plasma-devel mailing list