Review Request: Fixes a crash in Qalculate applet (bug 241006)

[Matteo Agostinelli]

> On 2010-06-09 16:00:53, Aaron Seigo wrote:
> > /trunk/KDE/kdeplasma-addons/applets/qalculate/qalculate_history.cpp, lines 41-60
> > <http://reviewboard.kde.org/r/4265/diff/1/?file=28257#file28257line41>
> >
> >     these changes aren't part of the fix, correct? just clean ups?

Yes, exactly. Only clean-ups since I was messing with the code there.


- Matteo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4265/#review6055
-----------------------------------------------------------


On 2010-06-09 14:22:07, Matteo Agostinelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4265/
> -----------------------------------------------------------
> 
> (Updated 2010-06-09 14:22:07)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch fixes a crash when browsing the history in the Qalculate plasmoid. The crash can be reproduced by activating the input line in the applet and then pressing an arrow key (up or down). It fixes bug http://bugs.kde.org/show_bug.cgi?id=241006
> 
> 
> This addresses bug 241006.
>     https://bugs.kde.org/show_bug.cgi?id=241006
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/qalculate/qalculate_history.cpp 1132579 
> 
> Diff: http://reviewboard.kde.org/r/4265/diff
> 
> 
> Testing
> -------
> 
> Tested with no crashes
> 
> 
> Thanks,
> 
> Matteo
> 
>