Review Request: Plasma Mediacenter: Inroduce displaying and modifying of nepomuk tags

[Markus Slopianka]

> On 2010-06-07 22:45:45, Markus Slopianka wrote:
> > Correct me if I missed anything, but as I skimmed through the diff, it looked to me that this is only about Nepomuk tags. Correct?
> > I may be splitting hairs here, but when I hear "tag editing" in the context of media players, I think of ID3 tags and such.

Will ID3 tags later be edited with the same mechanism? (At least Artist, Title, Year, ans such) If yes, the wording is OK to me and not editing ID3 tags is just a transitional bug. However, if ID3 tags will be edited with a different tool/window, I suggest to change the name of Nepomuk tags to something else, like "Label" or so, to avoid confusion.


- Markus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4252/#review6028
-----------------------------------------------------------


On 2010-06-08 08:03:13, Christophe Olinger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4252/
> -----------------------------------------------------------
> 
> (Updated 2010-06-08 08:03:13)
> 
> 
> Review request for Plasma and Alessandro Diaferia.
> 
> 
> Summary
> -------
> 
> This patch introduces a new label in the bottom bar. When playing/looking at a media file, it displays its nepomuk tags. When clicking on the label, the user can add/edit tags to an item (comma separated). When multiple items are selected, tags are applied to all of them.
> 
> P.S. The videostate.cpp contains comments.
> 
> 
> Diffs
> -----
> 
>   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.h 1135839 
>   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.cpp 1135839 
>   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.h 1135839 
>   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.cpp 1135839 
>   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.h 1135839 
>   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.cpp 1135839 
>   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.h 1135839 
>   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.cpp 1135839 
>   trunk/playground/base/plasma/MediaCenterComponents/shells/plasmediacenter/mainwindow.cpp 1135839 
> 
> Diff: http://reviewboard.kde.org/r/4252/diff
> 
> 
> Testing
> -------
> 
> Adding, editing tags was tested extensively. No more bugs should remain (TM)
> 
> 
> Thanks,
> 
> Christophe
> 
>