Review Request: Plasma Mediacenter: Inroduce displaying and modifying of nepomuk tags

Christophe Olinger olingerc at binarylooks.com
Tue Jun 8 10:03:13 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4252/
-----------------------------------------------------------

(Updated 2010-06-08 08:03:13.711993)


Review request for Plasma and Alessandro Diaferia.


Changes
-------

The initial patch had a little bug that caused crashes on state exit. Fixed now.


Summary
-------

This patch introduces a new label in the bottom bar. When playing/looking at a media file, it displays its nepomuk tags. When clicking on the label, the user can add/edit tags to an item (comma separated). When multiple items are selected, tags are applied to all of them.

P.S. The videostate.cpp contains comments.


Diffs (updated)
-----

  trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.h 1135839 
  trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.cpp 1135839 
  trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.h 1135839 
  trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.cpp 1135839 
  trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.h 1135839 
  trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.cpp 1135839 
  trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.h 1135839 
  trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.cpp 1135839 
  trunk/playground/base/plasma/MediaCenterComponents/shells/plasmediacenter/mainwindow.cpp 1135839 

Diff: http://reviewboard.kde.org/r/4252/diff


Testing
-------

Adding, editing tags was tested extensively. No more bugs should remain (TM)


Thanks,

Christophe



More information about the Plasma-devel mailing list