Review Request: 'fix' layout of notifications config page
Hugo Pereira Da Costa
hugo at oxygen-icons.org
Sun Jun 6 23:07:55 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4246/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
In the current "notifications" config page, checkboxes are presented with right aligned labels, and checkboxes on the right of these labels. As far as I know, this layout is used nowhere else in various UIs, and neither me nor Pinheiro could find a reason for this unusual layout. Is there any ?
This patch restores "normal" layout, with checkboxes on the left, and left-aligned labels, right of the checkbox.
See screenshots.
Diffs
-----
/trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationsconfig.ui 1135215
Diff: http://reviewboard.kde.org/r/4246/diff
Testing
-------
oxygen + trunk
Screenshots
-----------
current layout
http://reviewboard.kde.org/r/4246/s/425/
proposed layout
http://reviewboard.kde.org/r/4246/s/426/
Thanks,
Hugo
More information about the Plasma-devel
mailing list