Review Request: use portable KDiskFreeSpaceInfo for free space calculation

[Alessandro Diaferia]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4241/#review6000
-----------------------------------------------------------

Ship it!


Can't imagine anything saner than this. Of course last word to Christopher.

- Alessandro


On 2010-06-06 13:15:14, Pino Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4241/
> -----------------------------------------------------------
> 
> (Updated 2010-06-06 13:15:14)
> 
> 
> Review request for Plasma and Christopher Blauvelt.
> 
> 
> Summary
> -------
> 
> Currently, the soliddevice data engine use either statvfs() or statfs() for determine the free space on a mount point.
> This, other than requiring per-OS code which does not cover all the OS KDE supports (for example Windows), is already wrapped in a nice API in kio, the class KDiskFreeSpaceInfo.
> 
> The proposed patch applies this class to the soliddevice data engine, although making it depend on kio.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/soliddevice/CMakeLists.txt 1135061 
>   /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/soliddevice/soliddeviceengine.cpp 1135061 
> 
> Diff: http://reviewboard.kde.org/r/4241/diff
> 
> 
> Testing
> -------
> 
> Looks reporting the correct value for mounted mount points, when queried via plasmaengineexplorer.
> 
> 
> Thanks,
> 
> Pino
> 
>