[PATCH] Fix kickof bug 231791 allowing apps dropping in the favorites view

[Sebastian Kügler]

On Saturday 22 May 2010 21:02:25 Chani wrote:
> On May 22, 2010 09:03:53 Alessandro Diaferia wrote:
> > Hullo,
> > it seems reviewboard cannot connect to anonsvn (at least from here) so
> > i'm attaching the patch here as it is really small.
> >
> > 
> >
> > Having a look at https://bugs.kde.org/show_bug.cgi?id=231791 you can see
> > how easy is reproducing the bug.
> > It seems that kickoff does not allow adding favorites via D&D. D&D is
> > only used to move items in the list.
> > This little patch allows adding favorites via D&D dragging from the
> > application view to the favorites one.
> > I just don't know if this is considered as a new feature. It seems to me
> > that this patch just makes kickoff behaving as it is expected to behave.
> >
> > 
> >
> > Anyway the last word is yours of course, plasma-friends :)
> >
> > 
> >
> > Regards.
> 
> hmm. no comment on whether it's a feature..  code looks sensible, although 
> wouldn't it be more future-proof to iterate over data->urls() instead of
> only  taking the first?

That would be an easy way to support dropping a whole directory into the Favorite. I 
think it's kind of cool, although it might actually be a disservice to those doing it 
accidentally (and adding a whole bunch of things to that tab at once sounds like a 
cornercase, anyway).
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9