Review Request: battery: Support for any amount of brightness devices

[Sebastian Kügler]

> On 2010-07-30 14:54:15, Rafa? Mi?ecki wrote:
> > /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp, line 528
> > <http://reviewboard.kde.org/r/4796/diff/1/?file=31992#file31992line528>
> >
> >     Naming devices would be great, however names seems to be like: "/org/freedesktop/Hal/devices/computer_backlight".
> >     Should we just take untranslated "computer_backlight" part? Or should we enumerate them?
> >     
> >     As about adding every device, I don't think there will be (any/many) cases with more than 1 device. It's unlikely any user will be overhelmed with amount of devices.

Okay, makes sense. I hadn't understood that this patch is mainly about hiding brightness controls, not showing multiple. Makes sense.


> On 2010-07-30 14:54:15, Rafa? Mi?ecki wrote:
> > /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp, line 436
> > <http://reviewboard.kde.org/r/4796/diff/1/?file=31992#file31992line436>
> >
> >     Good catch, that's right. Could we actually drop whole Battery::setFullBrightness? It was introduced by sebas in 866073 and doesn't seem to be used anymore.

Yep, drop it.


> On 2010-07-30 14:54:15, Rafa? Mi?ecki wrote:
> > /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp, line 412
> > <http://reviewboard.kde.org/r/4796/diff/1/?file=31992#file31992line412>
> >
> >     brightnessChanged is slot for Slider and without checking whole m_brightnessSliders I can not say what device is associated with slider that sent signal.
> >     Maybe you just did't note I use db->device as parameter of setBrightness call.

Ok, re-read the code and got it now. :)


> On 2010-07-30 14:54:15, Rafa? Mi?ecki wrote:
> > /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp, line 643
> > <http://reviewboard.kde.org/r/4796/diff/1/?file=31992#file31992line643>
> >
> >     I have no idea, I've just copied current behavior. What should I do about this part, then?

Ah, right. Just leave it in that case. :)


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4796/#review6748
-----------------------------------------------------------


On 2010-07-30 08:23:16, Rafa? Mi?ecki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4796/
> -----------------------------------------------------------
> 
> (Updated 2010-07-30 08:23:16)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Currently we always display one brightness slider, even if there is not br device at all (see bug #199520) or if there are more devices that should be controlled.
> 
> With this patch we fetch all devices and generate one label&slider pair for each.
> 
> The most confusing thing for me in implementation was storing list of sliders assigned to devices names. For that purpose I introduced struct BrightnessSet. I don't know if it is clean and acceptable solution, however keeping something like
> QMap<QPair<Plasma::Label *, Plasma::Slider *> > *m_brightnessControlls
> didn't sound too great to me.
> 
> 
> This addresses bug 199520.
>     https://bugs.kde.org/show_bug.cgi?id=199520
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.h 1156862 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp 1156862 
> 
> Diff: http://reviewboard.kde.org/r/4796/diff
> 
> 
> Testing
> -------
> 
> I don't have two brightness devices, so I didn't test that part.
> 
> After removing "video" kernel module I didn't get any slider which is good.
> 
> I also put some:
> qDebug() << "setting" << bs->device
> to make sure my list of names and sliders works fine.
> 
> 
> Thanks,
> 
> Rafa?
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100731/a285c9f4/attachment-0001.htm