Review Request: battery: Support for any amount of brightness devices

[Rafa? Mi?ecki]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4796/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Currently we always display one brightness slider, even if there is not br device at all (see bug #199520) or if there are more devices that should be controlled.

With this patch we fetch all devices and generate one label&slider pair for each.

The most confusing thing for me in implementation was storing list of sliders assigned to devices names. For that purpose I introduced struct BrightnessSet. I don't know if it is clean and acceptable solution, however keeping something like
QMap<QPair<Plasma::Label *, Plasma::Slider *> > *m_brightnessControlls
didn't sound too great to me.


This addresses bug 199520.
    https://bugs.kde.org/show_bug.cgi?id=199520


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.h 1156862 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp 1156862 

Diff: http://reviewboard.kde.org/r/4796/diff


Testing
-------

I don't have two brightness devices, so I didn't test that part.

After removing "video" kernel module I didn't get any slider which is good.

I also put some:
qDebug() << "setting" << bs->device
to make sure my list of names and sliders works fine.


Thanks,

Rafa?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100730/0f1cacd9/attachment.htm