Review Request: Folderview : label when empty folder

[Aaron Seigo]

> On 2010-07-23 18:31:44, Aaron Seigo wrote:
> > looks good to me; as long as Frederik is cool with it as well (as he is the author/maintainer of folderview :), then this should go in
> 
> Iamluc wrote:
>     Thanks.
>     I do not have a SVN account, so if you could commit it.... (Of course if Frederik is OK !) :-)

ok, i'll work on integrating & testing it today.

btw, if you wish to continue submitting patches (and i hope you do! i see you posted another one for kio, e.g. :), then we should get you your own account so you can do the committing and what not yourself :)


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4519/#review6693
-----------------------------------------------------------


On 2010-07-22 17:14:18, Iamluc wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4519/
> -----------------------------------------------------------
> 
> (Updated 2010-07-22 17:14:18)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Hello,
> 
> This patch add a Plasma::Label with text "This folder is empty." in Folderview's Popup when the folder is empty.
> 
> The related bug number in kde bugzilla is 201542.
> 
> Luc
> 
> 
> This addresses bug 201542.
>     https://bugs.kde.org/show_bug.cgi?id=201542
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1151820 
>   /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1151820 
> 
> Diff: http://reviewboard.kde.org/r/4519/diff
> 
> 
> Testing
> -------
> 
> Delete/add files several times. The label disappears/appears correctly.
> 
> 
> Screenshots
> -----------
> 
> folderview empty folder
>   http://reviewboard.kde.org/r/4519/s/444/
> version 2
>   http://reviewboard.kde.org/r/4519/s/455/
> 
> 
> Thanks,
> 
> Iamluc
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100726/c1c2f9ba/attachment-0001.htm