Review Request: Manual panel hiding [WIP]

Aaron Seigo aseigo at kde.org
Mon Jul 26 20:23:08 CEST 2010



> On 2010-05-04 03:49:54, Aaron Seigo wrote:
> > any updates on this?
> 
> Will Stephenson wrote:
>     Ditto - our users are still asking for it - as they do on every release.

*gasp* all of them? ;)

more seriously, "our users" as a generic term is not a very interesting metric, since in reality it could be 10 loud users out of 1000 or it could be an actually significant %. :)

that said ... looks like this patch is abandoned. would be nice if someone picked it up and finished it out.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3121/#review5390
-----------------------------------------------------------


On 2010-03-04 19:19:53, Andrzej JR Hunt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3121/
> -----------------------------------------------------------
> 
> (Updated 2010-03-04 19:19:53)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Manual panel hiding patch (still in progress). Currently only horizontal panels are properly implemented, there is still a display bug whereby the plasma toolbox (cashew) ignores the contentsMargins set on the containment and thus gets covered by the hiding buttons.
> 
> 
> This addresses bug 158556.
>     https://bugs.kde.org/show_bug.cgi?id=158556
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.h 1097398 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.cpp 1097398 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.h 1097398 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.cpp 1097398 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/scripting/panel.cpp 1097398 
> 
> Diff: http://reviewboard.kde.org/r/3121/diff
> 
> 
> Testing
> -------
> 
> Hiding the panels, changing states, changing positions and sizes.
> 
> 
> Thanks,
> 
> Andrzej JR
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100726/51ddf09d/attachment.htm 


More information about the Plasma-devel mailing list