Review Request: new KWin effect: Dashboard
Martin Gräßlin
kde at martin-graesslin.com
Fri Jul 23 17:48:54 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4332/#review6689
-----------------------------------------------------------
Ship it!
At least for KWin part this is a ship It. If nobody comments on the plasma part, just go ahead. Btw there are a few red markings in the diff.
- Martin
On 2010-07-21 13:52:16, Andreas Demmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4332/
> -----------------------------------------------------------
>
> (Updated 2010-07-21 13:52:16)
>
>
> Review request for kwin and Plasma.
>
>
> Summary
> -------
>
> This patch adds a new KWin effect that allows to modify the appearance of the Plasma dashboard. It has a KCM configuration dialog where you can adjust brightness, saturation and blur of the dashboard background. Blur depends on the loaded blur plugin.
>
> I also patched the Plasma dashboard to recognize the loaded effect: If the effect is loaded, the dashboard draws its background fully translucent. In order for the Dashboard to recognize wether the effect is loaded, I added support for the effect in Plasma::WindowEffects from kdelibs.
>
> The dashboard detection in the effect itself is hackish right now. As soon as Plasma adds a proper class to the dashboard window, I will replace the hack with a class-check.
>
>
> This addresses bugs dashboard, detection and hackish.
> https://bugs.kde.org/show_bug.cgi?id=dashboard
> https://bugs.kde.org/show_bug.cgi?id=detection
> https://bugs.kde.org/show_bug.cgi?id=hackish
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt 1152500
> trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.cpp 1152500
> trunk/KDE/kdebase/workspace/kwin/effects/configs_builtins.cpp 1152500
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/CMakeLists.txt PRE-CREATION
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp PRE-CREATION
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop PRE-CREATION
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.h PRE-CREATION
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.desktop PRE-CREATION
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h PRE-CREATION
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp PRE-CREATION
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.ui PRE-CREATION
> trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h 1152500
> trunk/KDE/kdebase/workspace/plasma/desktop/shell/dashboardview.cpp 1152500
> trunk/KDE/kdelibs/plasma/windoweffects.h 1152494
> trunk/KDE/kdelibs/plasma/windoweffects.cpp 1152494
>
> Diff: http://reviewboard.kde.org/r/4332/diff
>
>
> Testing
> -------
>
> Code compiles, plugin loads, plugin configuration dialog is registered in KCM Workspace module under "all effects". If the plugin is enabled, its settings apply to the dashboard.
>
>
> Screenshots
> -----------
>
> configuration dialog
> http://reviewboard.kde.org/r/4332/s/434/
> dashboard with modified background
> http://reviewboard.kde.org/r/4332/s/435/
>
>
> Thanks,
>
> Andreas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100723/b353551d/attachment.htm
More information about the Plasma-devel
mailing list