Review Request: Folderview : label when empty folder

[Iamluc]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4519/
-----------------------------------------------------------

(Updated 2010-07-22 17:14:18.528780)


Review request for Plasma.


Changes
-------

Avoid full repaint when not necessary by using a bool m_folderIsEmpty.

Add Aaron changes to hide the message when folderview is used as a containment


Summary
-------

Hello,

This patch add a Plasma::Label with text "This folder is empty." in Folderview's Popup when the folder is empty.

The related bug number in kde bugzilla is 201542.

Luc


This addresses bug 201542.
    https://bugs.kde.org/show_bug.cgi?id=201542


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1151820 
  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1151820 

Diff: http://reviewboard.kde.org/r/4519/diff


Testing
-------

Delete/add files several times. The label disappears/appears correctly.


Screenshots
-----------

folderview empty folder
  http://reviewboard.kde.org/r/4519/s/444/
version 2
  http://reviewboard.kde.org/r/4519/s/455/


Thanks,

Iamluc

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100722/1a34c57b/attachment.htm