Review Request: Add plasma ToolTip to fileWatcher

Aaron Seigo aseigo at kde.org
Wed Jul 21 17:45:41 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4730/#review6657
-----------------------------------------------------------

Ship it!


good idea, one small change and it can go in :)


trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcher.h
<http://reviewboard.kde.org/r/4730/#comment6401>

    it isn't necessary to keep a copy of the ToolTipContent.


- Aaron


On 2010-07-21 07:48:03, Sinny Kumari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4730/
> -----------------------------------------------------------
> 
> (Updated 2010-07-21 07:48:03)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Previously,in fileWatcher widget , during hovering it was showing the path of file added to it in traditional QtToolTip format.
> So,i changed its hovering effect to the plasma::tooltip style which looks very nice.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcher.h 1148418 
>   trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcher.cpp 1148418 
> 
> Diff: http://reviewboard.kde.org/r/4730/diff
> 
> 
> Testing
> -------
> 
> It works fine with Trunk.
> 
> 
> Thanks,
> 
> Sinny
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100721/5947dc37/attachment-0001.htm 


More information about the Plasma-devel mailing list