Review Request: Folderview : label when empty folder

[Iamluc]

> On 2010-07-19 20:39:45, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, lines 1234-1236
> > <http://reviewboard.kde.org/r/4519/diff/3/?file=30944#file30944line1234>
> >
> >     if it is a containment, rather than used as a widget, it probably shouldn't paint this.

Sorry, I am not sure to understand.

In Diff revision 1, instead of painting directly the message, a signal was emited to PopupView, which display a label with the text (As it works for the BusyWidget).
Is this what you mean ?

Thanks for your review.


> On 2010-07-19 20:39:45, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, lines 508-509
> > <http://reviewboard.kde.org/r/4519/diff/3/?file=30944#file30944line508>
> >
> >     this will cause a full repaint of the entire folderview widget every time the listing is completed. it would be good to find a way to trigger it only when needed.
> >     
> >     i assume this happens only when the file count change to or from 0.
> >     
> >     this would probably mean having to keep some state to know when it is/was empty, and only when it becomes empty or is no longer empty then call for a full update().

It was like this in Diff revision 2. If it is OK, I can prepare a new version of the patch.


- Iamluc


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4519/#review6643
-----------------------------------------------------------


On 2010-07-12 17:13:34, Iamluc wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4519/
> -----------------------------------------------------------
> 
> (Updated 2010-07-12 17:13:34)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Hello,
> 
> This patch add a Plasma::Label with text "This folder is empty." in Folderview's Popup when the folder is empty.
> 
> The related bug number in kde bugzilla is 201542.
> 
> Luc
> 
> 
> This addresses bug 201542.
>     https://bugs.kde.org/show_bug.cgi?id=201542
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1145373 
> 
> Diff: http://reviewboard.kde.org/r/4519/diff
> 
> 
> Testing
> -------
> 
> Delete/add files several times. The label disappears/appears correctly.
> 
> 
> Screenshots
> -----------
> 
> folderview empty folder
>   http://reviewboard.kde.org/r/4519/s/444/
> version 2
>   http://reviewboard.kde.org/r/4519/s/455/
> 
> 
> Thanks,
> 
> Iamluc
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100720/0e78bc51/attachment.htm