Review Request: Adds support for corner widgets in Plasma::TabBar

[Giulio Camuffo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4537/
-----------------------------------------------------------

(Updated 2010-07-11 21:06:03.666064)


Review request for Plasma and Marco Martin.


Changes
-------

use QWeakPointer
delete the previous widget
take the ownership of the widget
declare two Q_PROPERTIES for them.


Summary
-------

This patch adds two methods that allow to put two QGraphicsWidget in the top left and top right corner of the tab bar, like it is possible with QTabWidget.


Diffs (updated)
-----

  trunk/KDE/kdelibs/plasma/widgets/tabbar.h 1147219 
  trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp 1147219 

Diff: http://reviewboard.kde.org/r/4537/diff


Testing
-------

Tested, it works, but there's one thing that annoys me and I don't how to solve in a clean way: when there are no tabs the NativeTabBar becomes a bit smaller in height and the widgets resize accordingly.


Screenshots
-----------

added two Plasma::PushButton
  http://reviewboard.kde.org/r/4537/s/446/


Thanks,

Giulio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100711/130dd87e/attachment.htm