Review Request: Launcher support for libtaskmanager
Markus Slopianka
kamikazow at web.de
Sat Jul 10 20:04:59 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4585/#review6469
-----------------------------------------------------------
Um, I think that was done by accident:
/kdebase/workspace/libs/taskmanager/launcheritem.h is GPL while /kdebase/workspace/libs/taskmanager/launcheritem.cpp is under a BSD license.
Shouldn't both be BSDL'ed?
- Markus
On 2010-07-10 17:21:34, Anton Kreuzkamp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4585/
> -----------------------------------------------------------
>
> (Updated 2010-07-10 17:21:34)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Adds support for Windows 7 like launchers in libtaskmanager.
> (I'm on holliday from 12th July until 1st August so I will not be able to reply during this time.)
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h 1148442
> /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp 1148442
> /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h 1148442
> /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/programgroupingstrategy.cpp 1148442
> /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp PRE-CREATION
> /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h PRE-CREATION
> /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1148442
> /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h 1148442
> /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h 1148442
> /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp 1148442
> /trunk/KDE/kdebase/workspace/libs/taskmanager/CMakeLists.txt 1148442
>
> Diff: http://reviewboard.kde.org/r/4585/diff
>
>
> Testing
> -------
>
> Tested with a small test-applett and everything works.
>
>
> Thanks,
>
> Anton
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100710/91db43ea/attachment.htm
More information about the Plasma-devel
mailing list