Review Request: Fix a bogus message indicator item in hidden system tray popup

[Octavian Voicu]

> On 2010-07-09 11:50:08, Aurélien Gâteau wrote:
> > Judging from this screenshot from the bugreport http://bugsfiles.kde.org/attachment.cgi?id=48278, it seems the system is running Kubuntu Plasma Message Indicator, which happens to be named message-indicator. Could this be the cause of the problem?
> 
> Aurélien Gâteau wrote:
>     links works better without the comma: http://bugsfiles.kde.org/attachment.cgi?id=48278

I have the plasma-widget-message-indicator package installed (KDE SC 4.5 RC from Kubuntu 9.10 ppa).

I uninstalled the above package, logged out, deleted the /.kde/share/config/plasma-desktop-appletsrc config file, logged back in and there was no message indicator visible. Then I reinstalled the package, logged out, logged back in, and there I had it: both message indicators (the real one and the fake one).

The application that actually uses the message indicator is Pidgin (version 2.7.1). As I said in the original report, the bogus item, when clicked, shows the same thing as when I click the real one (which is usually not hidden; the bogus one is always hidden).

Which should be the correct name of the widget in the latest version, message-indicator or notifier? If it's the latter, how come it also recognizes message-indicator and starts it up?


- Octavian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4541/#review6440
-----------------------------------------------------------


On 2010-07-08 21:06:50, Octavian Voicu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4541/
> -----------------------------------------------------------
> 
> (Updated 2010-07-08 21:06:50)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Possible fix for a bug in KDE system tray component.
> 
> I'm not up-to-date with recent plasma changes, but I'm guessing that at some
> point the `Message Indicator' widget changed its plugin name from `notifier' to
> `message-indicator'.
> 
> The system tray applet, when invoked for the first time, tries to make sure
> essential widgets are included, and adds `notifier' (the old "fake" message
> indicator), when it should probably add `message-indicator'.
> 
> Excerpt from ~/.kde/share/config/plasma-desktop-appletsrc:
> 
> [Containments][4][Applets][10][Configuration][Applets][2]
> plugin=message-indicator
> ...
> 
> [Containments][4][Applets][10][Configuration][Applets][3]
> plugin=notifier
> ...
> 
> I attached a fix for this, which adds `message-indicator' instead of
> `notifier'. An alternative fix would be to delete the offending lines entirely,
> but I'm guessing we want the message indicator widget to show up by default.
> 
> For screenshot and more info see https://bugs.kde.org/show_bug.cgi?id=242637
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/applet.cpp 1144396 
> 
> Diff: http://reviewboard.kde.org/r/4541/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Octavian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100709/5997e62f/attachment-0001.htm