Review Request: Fix a bogus message indicator item in hidden system tray popup

[Octavian Voicu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4541/
-----------------------------------------------------------

(Updated 2010-07-08 21:06:50.086050)


Review request for Plasma.


Summary (updated)
-------

Possible fix for a bug in KDE system tray component.

I'm not up-to-date with recent plasma changes, but I'm guessing that at some
point the `Message Indicator' widget changed its plugin name from `notifier' to
`message-indicator'.

The system tray applet, when invoked for the first time, tries to make sure
essential widgets are included, and adds `notifier' (the old "fake" message
indicator), when it should probably add `message-indicator'.

Excerpt from ~/.kde/share/config/plasma-desktop-appletsrc:

[Containments][4][Applets][10][Configuration][Applets][2]
plugin=message-indicator
...

[Containments][4][Applets][10][Configuration][Applets][3]
plugin=notifier
...

I attached a fix for this, which adds `message-indicator' instead of
`notifier'. An alternative fix would be to delete the offending lines entirely,
but I'm guessing we want the message indicator widget to show up by default.

For screenshot and more info see https://bugs.kde.org/show_bug.cgi?id=242637


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/applet.cpp 1144396 

Diff: http://reviewboard.kde.org/r/4541/diff


Testing
-------


Thanks,

Octavian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100708/111f3567/attachment.htm