Review Request: Folderview : label when empty folder

[Iamluc]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4519/
-----------------------------------------------------------

(Updated 2010-07-08 19:22:01.397461)


Review request for Plasma.


Changes
-------

New version using IconView::paintMessage() (no more signal/slot)

Fredrik, thanks for your help.

Simon, I'm sorry, I tried to reduce the size of the popup, but it didn't work.
In fact, the popup is visible before we know if there are items or not. And resizing it after it appears is really ugly !


Summary
-------

Hello,

This patch add a Plasma::Label with text "This folder is empty." in Folderview's Popup when the folder is empty.

The related bug number in kde bugzilla is 201542.

Luc


This addresses bug 201542.
    https://bugs.kde.org/show_bug.cgi?id=201542


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1145373 
  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1145373 

Diff: http://reviewboard.kde.org/r/4519/diff


Testing
-------

Delete/add files several times. The label disappears/appears correctly.


Screenshots
-----------

folderview empty folder
  http://reviewboard.kde.org/r/4519/s/444/


Thanks,

Iamluc

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100708/4b70cd22/attachment.htm