Review Request: Folderview : label when empty folder
Iamluc
luc at vieillescazes.net
Thu Jul 8 11:52:36 CEST 2010
> On 2010-07-08 08:31:35, Beat Wolf wrote:
> > Looks good to me, and trunk is open again.
Thanks you for the review.
I don't have an SVN account yet (and I think it's too early to ask one). So could you please commit the patch for me ?
- Iamluc
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4519/#review6422
-----------------------------------------------------------
On 2010-07-03 17:11:02, Iamluc wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4519/
> -----------------------------------------------------------
>
> (Updated 2010-07-03 17:11:02)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Hello,
>
> This patch add a Plasma::Label with text "This folder is empty." in Folderview's Popup when the folder is empty.
>
> The related bug number in kde bugzilla is 201542.
>
> Luc
>
>
> This addresses bug 201542.
> https://bugs.kde.org/show_bug.cgi?id=201542
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1145373
> /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1145373
> /trunk/KDE/kdebase/apps/plasma/applets/folderview/popupview.h 1145373
> /trunk/KDE/kdebase/apps/plasma/applets/folderview/popupview.cpp 1145373
>
> Diff: http://reviewboard.kde.org/r/4519/diff
>
>
> Testing
> -------
>
> Delete/add files several times. The label disappears/appears correctly.
>
>
> Screenshots
> -----------
>
> folderview empty folder
> http://reviewboard.kde.org/r/4519/s/444/
>
>
> Thanks,
>
> Iamluc
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100708/b91fa135/attachment-0001.htm
More information about the Plasma-devel
mailing list