Review Request: new KWin effect: Dashboard

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4332/#review6365
-----------------------------------------------------------


There are only small issues left - mostly coding style. Yeah I know KWin style kind of sucks, especially if you are used to write with KDE-Libs coding style. Nevertheless please have a look on a consistent style :-) The remarks to style I made in the code are only examples, there are more style issues I noticed.


trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp
<http://reviewboard.kde.org/r/4332/#comment6099>

    coding style :-)



trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp
<http://reviewboard.kde.org/r/4332/#comment6100>

    coding style - after if always new line



trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp
<http://reviewboard.kde.org/r/4332/#comment6102>

    I'm not really sure if it is a good idea to make the blur option only available if blur is loaded. I can imagine situation like setting up the effects without having compositing enabled. Maybe it's better to just have the textbox and add a comment that blur effect is required for this option to work.
    
    This would also remove the Plasma dependency in the KCMs.



trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h
<http://reviewboard.kde.org/r/4332/#comment6101>

    You should also use the namespace in the define, so KWIN_DASHBOARD_CONFIG_H



trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h
<http://reviewboard.kde.org/r/4332/#comment6103>

    I would not call it "Force"Blur. Just Blur. The other role is called Force, because it really forces blur in a code path where blur would be disabled.


- Martin


On 2010-06-29 19:29:38, Andreas Demmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4332/
> -----------------------------------------------------------
> 
> (Updated 2010-06-29 19:29:38)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds a new KWin effect that allows to modify the appearance of the Plasma dashboard. It has a KCM configuration dialog where you can adjust brightness, saturation and blur of the dashboard background. Blur depends on the loaded blur plugin.
> 
> I also patched the Plasma dashboard to recognize the loaded effect: If the effect is loaded, the dashboard draws its background fully translucent. In order for the Dashboard to recognize wether the effect is loaded, I added support for the effect in Plasma::WindowEffects from kdelibs.
> 
> The dashboard detection in the effect itself is hackish right now. As soon as Plasma adds a proper class to the dashboard window, I will replace the hack with a class-check.
> 
> 
> This addresses bugs dashboard, detection and hackish.
>     https://bugs.kde.org/show_bug.cgi?id=dashboard
>     https://bugs.kde.org/show_bug.cgi?id=detection
>     https://bugs.kde.org/show_bug.cgi?id=hackish
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt 1144343 
>   trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.cpp 1144343 
>   trunk/KDE/kdebase/workspace/kwin/effects/configs_builtins.cpp 1144343 
>   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/CMakeLists.txt PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.h PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.desktop PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.ui PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h 1144343 
>   trunk/KDE/kdebase/workspace/plasma/desktop/shell/dashboardview.cpp 1144343 
>   trunk/KDE/kdelibs/plasma/windoweffects.h 1144345 
>   trunk/KDE/kdelibs/plasma/windoweffects.cpp 1144345 
> 
> Diff: http://reviewboard.kde.org/r/4332/diff
> 
> 
> Testing
> -------
> 
> Code compiles, plugin loads, plugin configuration dialog is registered in KCM Workspace module under "all effects". If the plugin is enabled, its settings apply to the dashboard.
> 
> 
> Screenshots
> -----------
> 
> configuration dialog
>   http://reviewboard.kde.org/r/4332/s/434/
> dashboard with modified background
>   http://reviewboard.kde.org/r/4332/s/435/
> 
> 
> Thanks,
> 
> Andreas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100705/bb736533/attachment.htm