Review Request: Fix segmentation fault at plasma_applet_animation_example

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2738/#review3970
-----------------------------------------------------------


will fix this in svn, but good to keep in mind for future :)


trunk/KDE/kdelibs/plasma/animations/rotationstacked.cpp
<http://reviewboard.kde.org/r/2738/#comment3352>

    btw, why not just:
    
    m_wLayout = new StackedLayout;
    
    m_sLayout is the wrong naming in any case for a local variable :)



trunk/KDE/kdelibs/plasma/animations/rotationstacked.cpp
<http://reviewboard.kde.org/r/2738/#comment3353>

    don't need to check this; "delete 0;" is completely valid. so just:
    
    delete m_wLayout.data();
    
    the clear() on the next line isn't needed either


- Aaron


On 2010-01-29 19:32:53, loureiro wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2738/
> -----------------------------------------------------------
> 
> (Updated 2010-01-29 19:32:53)
> 
> 
> Review request for Plasma, Aaron Seigo, Marco Martin, igorto, and Adenilson Cavalcanti.
> 
> 
> Summary
> -------
> 
> This is a small patch that fix a segmentation fault at plasma_applet_animation_example when we close the window.
> Basically I remove the delete sentence at the RotationStackedAnimation's destruct, I made it because I think when we create a QGraphicsLinearLayout passing a widget that widget will be the owner and responsible to delete it as well its children elements and running the example under valgrind I don't get leaks.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/animations/rotationstacked.cpp 1082016 
>   trunk/KDE/kdelibs/plasma/animations/rotationstacked_p.h 1082016 
>   trunk/KDE/kdelibs/plasma/animations/stackedlayout.h 1082016 
>   trunk/KDE/kdelibs/plasma/animations/stackedlayout.cpp 1082016 
> 
> Diff: http://reviewboard.kde.org/r/2738/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> loureiro
> 
>