Review Request: save/restore containments

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2713/#review3910
-----------------------------------------------------------


"make it activity-centric instead of containment-centric"

Activity is a user interface word and a concept of plasma-desktop / plasma-netbook / etc. Containment is the libplasma API :)


/trunk/KDE/kdelibs/plasma/containment.h
<http://reviewboard.kde.org/r/2713/#comment3284>

    export, with an optional a URL target?
    
    then close() would become the equivalent of:
    
    export();
    destroy();



/trunk/KDE/kdelibs/plasma/containment.cpp
<http://reviewboard.kde.org/r/2713/#comment3286>

    catching duplicates might be a good idea as well to avoid unintentional overwrites, not to mention if the containment isn't named or to catch the case where a containment is exported and then renamed.
    
    iirc, Ivan has a system for mapping UUIDs to Containments for use with nepomuk; perhaps that same system can be used here.



/trunk/KDE/kdelibs/plasma/containment.cpp
<http://reviewboard.kde.org/r/2713/#comment3285>

    this will end up not catching things that aren't saved out yet; the code should probably do:
    
    save(newConf);



/trunk/KDE/kdelibs/plasma/corona.h
<http://reviewboard.kde.org/r/2713/#comment3287>

    static?


- Aaron


On 2010-01-24 07:29:31, Chani Armitage wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2713/
> -----------------------------------------------------------
> 
> (Updated 2010-01-24 07:29:31)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> as expected, the libplasma side of closing & opening containments is pretty simple.
> getting hte right API and UI will be harder.
> there's no UI in this patch; I have a really ugly UI locally that basically just adds buttons to the activity bar to call these functions. I'm reluctant to commit bad UI; I'd rather someone take the API and make something pretty with it.
> 
> the API, though... hrm. well, tbh I'll probably need to redo it at tokamak to make it activity-centric instead of containment-centric. maybe have functions like openActivity and closeActivity?
> 
> maybe I should make Containment::close() take an optional filename... not something I personally would use, but the loading API leaves open hte option to pass it an arbitrary filename instead of one from the area containments are saved to.
> 
> I'd also like to add thumbnails to the saved containments in the future. I guess I could store them in the same folder under a related filename..? right now the containments are saved to $appdata/activities/$activityname but at some point nepomuk will give us UIDs to use instead (and then we'll need to extract the associated name to display in the UI, and deal with multi-monitor systems having >1 containment, and so on..)
> ok, I'm rambling now. I just don't want this code hiding on my laptop until tokamak :)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/containment.h 1077904 
>   /trunk/KDE/kdelibs/plasma/containment.cpp 1077904 
>   /trunk/KDE/kdelibs/plasma/corona.h 1077904 
>   /trunk/KDE/kdelibs/plasma/corona.cpp 1077904 
> 
> Diff: http://reviewboard.kde.org/r/2713/diff
> 
> 
> Testing
> -------
> 
> works surprisingly well, haven't been able to cause anything bad to happen
> 
> 
> Thanks,
> 
> Chani
> 
>