Review Request: Add city and country resolution to GPS geolocation data using geonames.

[Petri Damstén]

On Sunday 24 January 2010 17:18:49 Beat Wolf wrote:
> > On 2009-04-14 18:59:59, Aaron Seigo wrote:
> > > other than a couple of code style comments, and that i can't test it
> > > with a gps for you either :/, my only question/concern is that it's
> > > doing look ups on the internet without checking to see if we're
> > > connected. it could be in a local cache, but i'm going to guess that
> > > in a fairly typical "i'm using gps" scenario one won't have an
> > > internet connection as well. should we query solid for network status?
> > > 
> > > rambling off-topic here: i also wonder if we aren't going to want some
> > > "can use the internet for ..." settings somewhere for the case where
> > > we have a system with gps, cheap wifi and expensive g3 connectivity ..
> > > somethings, like looking up the place name on the internet, may not be
> > > acceptible even if there is g3 service? not a use case we actually
> > > have to deal with now, but it's something that pops into my head every
> > > once in a while .. .. like when i see a patch like this :)
> > 
> > Petri Damstén wrote:
> >     Dataengine already checks network state but since it thinks gps does
> >     not need one it uses gps plugin. I think location -> place should be
> >     a separate plugin. It's not possible with current code though and I
> >     would like to evaluate all the other possibilities before doing
> >     rewrite (there were some wlan etc ideas as well). For 4.3 should it
> >     go like this, I'm not sure?
> >     
> >     For 4.4 is geoclue out of the question? It seems that we are
> >     implementing pretty much all the same things.
> 
> any progress on this patch?

Attached is this patch converted to separate plugin. Tries to also fix plugins 
marked as NetworkConnected only to not to update when there is no network.

Petri
-------------- next part --------------
A non-text attachment was scrubbed...
Name: geolocation_name.diff
Type: text/x-patch
Size: 14801 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20100127/7db9c265/attachment-0001.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20100127/7db9c265/attachment-0001.sig