Review Request: Prefetching in Comic Strip plasmoid
Miha Cancula
miha.cancula at gmail.com
Mon Jan 25 11:19:39 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2636/
-----------------------------------------------------------
(Updated 2010-01-25 10:19:38.683488)
Review request for Plasma and Matthias Fuchs.
Changes
-------
Added current maintainer to People list.
Summary (updated)
-------
When a new strip is loaded, it caches both the previous and the next one, without interfering with the currently displayed comic. This is very useful if you're reading throug a particular comic, especially on slower connections. It's a two-line patch, but it greatly improves the experience for this use-case. Caching is done by the DataEngine, so no further modifications were needed.
After a discussion in the mailing list, the decision was to have no configuration for this, as the cost of downloading a single picture is qiute low.
Diffs
-----
/trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 1075738
Diff: http://reviewboard.kde.org/r/2636/diff
Testing
-------
I tested it on my Ubuntu machine with todays trunk. It works as expected, and I haven't noticed any regressions.
Thanks,
Miha
More information about the Plasma-devel
mailing list