Review Request: Allow to use the wallpapermode defined on the metadata.desktop

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2702/#review3820
-----------------------------------------------------------



/trunk/KDE/kdelibs/plasma/containment.cpp
<http://reviewboard.kde.org/r/2702/#comment3223>

    i don't think this is going to work, actually, if the user changes the configuration.
    
    the -defaults- should be retrieved from the metadata config only. something like:
    
    QString wallpaper = defaultWallpaper;
    QString mode = defaultWallpaperMode;
    if (metadata.hasGroup("Wallpaper")) {
        cfg = KConfigGroup(&metadata, "Wallpaper");
        wallpaper = cfg.readEntry("wallpaperplugin", wallpaper);
        mode = cfg.readEntry("wallpaperpluginmode", mode);
    }
    
    cfg = config();
    wallpaper = cfg.readEntry("wallpaperplugin", wallpaper);
    mode = cfg.readEntry("wallpaperpluginmode", mode);
    setWallpaper(wallpaper, mode);


- Aaron


On 2010-01-23 19:58:30, Nicolas Lécureuil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2702/
> -----------------------------------------------------------
> 
> (Updated 2010-01-23 19:58:30)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this patch add the possibility to define on the metadata.desktop the kind of wallpaper we want to use.
> If none is defined in the file, the default one will be used.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/containment.cpp 1078694 
> 
> Diff: http://reviewboard.kde.org/r/2702/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
>